From 2f38aca7b5a15d497caa0c4937f934e2b2e8306c Mon Sep 17 00:00:00 2001 From: GuillaumeSD Date: Tue, 27 May 2025 22:40:40 +0200 Subject: [PATCH] fix : move classification names rework --- public/icons/{good.png => okay.png} | Bin public/icons/{book.png => opening.png} | Bin public/icons/{great.png => perfect.png} | Bin src/components/board/index.tsx | 4 ++-- src/constants.ts | 6 +++--- src/lib/engine/helpers/moveClassification.ts | 10 +++++----- .../analysis/panelBody/analysisTab/moveInfo.tsx | 10 +++++----- .../movesClassificationsRecap/index.tsx | 6 +++--- .../classificationTab/movesPanel/moveItem.tsx | 2 +- src/sections/analysis/panelBody/graphTab/index.tsx | 2 +- src/types/enums.ts | 6 +++--- 11 files changed, 23 insertions(+), 23 deletions(-) rename public/icons/{good.png => okay.png} (100%) rename public/icons/{book.png => opening.png} (100%) rename public/icons/{great.png => perfect.png} (100%) diff --git a/public/icons/good.png b/public/icons/okay.png similarity index 100% rename from public/icons/good.png rename to public/icons/okay.png diff --git a/public/icons/book.png b/public/icons/opening.png similarity index 100% rename from public/icons/book.png rename to public/icons/opening.png diff --git a/public/icons/great.png b/public/icons/perfect.png similarity index 100% rename from public/icons/great.png rename to public/icons/perfect.png diff --git a/src/components/board/index.tsx b/src/components/board/index.tsx index 0b8174b..d02404b 100644 --- a/src/components/board/index.tsx +++ b/src/components/board/index.tsx @@ -215,9 +215,9 @@ export default function Board({ bestMove && showBestMoveArrow && moveClassification !== MoveClassification.Best && - moveClassification !== MoveClassification.Book && + moveClassification !== MoveClassification.Opening && moveClassification !== MoveClassification.Forced && - moveClassification !== MoveClassification.Great + moveClassification !== MoveClassification.Perfect ) { const bestMoveArrow = [ bestMove.slice(0, 2), diff --git a/src/constants.ts b/src/constants.ts index 85e7e16..d7305dc 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -5,13 +5,13 @@ export const TAB_ICONS_COLOR = "#FE7F2D"; export const LINEAR_PROGRESS_BAR_COLOR = "#3B9AC6"; export const CLASSIFICATION_COLORS: Record = { - [MoveClassification.Book]: "#dbac86", + [MoveClassification.Opening]: "#dbac86", [MoveClassification.Forced]: "#dbac86", [MoveClassification.Brilliant]: "#19d4af", - [MoveClassification.Great]: "#3894eb", + [MoveClassification.Perfect]: "#3894eb", [MoveClassification.Best]: "#22ac38", [MoveClassification.Excellent]: "#22ac38", - [MoveClassification.Good]: "#74b038", + [MoveClassification.Okay]: "#74b038", [MoveClassification.Inaccuracy]: "#f2be1f", [MoveClassification.Mistake]: "#e69f00", [MoveClassification.Blunder]: "#df5353", diff --git a/src/lib/engine/helpers/moveClassification.ts b/src/lib/engine/helpers/moveClassification.ts index 532bfbf..20a2c48 100644 --- a/src/lib/engine/helpers/moveClassification.ts +++ b/src/lib/engine/helpers/moveClassification.ts @@ -25,7 +25,7 @@ export const getMovesClassification = ( return { ...rawPosition, opening: opening.name, - moveClassification: MoveClassification.Book, + moveClassification: MoveClassification.Opening, }; } @@ -76,7 +76,7 @@ export const getMovesClassification = ( index > 1 ? [uciMoves[index - 2], uciMoves[index - 1]] : null; if ( - isGreatMove( + isPerfectMove( lastPositionWinPercentage, positionWinPercentage, isWhiteMove, @@ -88,7 +88,7 @@ export const getMovesClassification = ( return { ...rawPosition, opening: currentOpening, - moveClassification: MoveClassification.Great, + moveClassification: MoveClassification.Perfect, }; } @@ -128,7 +128,7 @@ const getMoveBasicClassification = ( if (winPercentageDiff < -20) return MoveClassification.Blunder; if (winPercentageDiff < -10) return MoveClassification.Mistake; if (winPercentageDiff < -5) return MoveClassification.Inaccuracy; - if (winPercentageDiff < -2) return MoveClassification.Good; + if (winPercentageDiff < -2) return MoveClassification.Okay; return MoveClassification.Excellent; }; @@ -183,7 +183,7 @@ const isLosingOrAlternateCompletelyWinning = ( return isLosing || isAlternateCompletelyWinning; }; -const isGreatMove = ( +const isPerfectMove = ( lastPositionWinPercentage: number, positionWinPercentage: number, isWhiteMove: boolean, diff --git a/src/sections/analysis/panelBody/analysisTab/moveInfo.tsx b/src/sections/analysis/panelBody/analysisTab/moveInfo.tsx index efab958..6d92d34 100644 --- a/src/sections/analysis/panelBody/analysisTab/moveInfo.tsx +++ b/src/sections/analysis/panelBody/analysisTab/moveInfo.tsx @@ -52,10 +52,10 @@ export default function MoveInfo() { const bestMoveLabel = moveClassification === MoveClassification.Best || - moveClassification === MoveClassification.Book || + moveClassification === MoveClassification.Opening || moveClassification === MoveClassification.Forced || moveClassification === MoveClassification.Brilliant || - moveClassification === MoveClassification.Great + moveClassification === MoveClassification.Perfect ? null : `${bestMoveSan} was the best move`; @@ -108,13 +108,13 @@ export default function MoveInfo() { } const moveClassificationLabels: Record = { - [MoveClassification.Book]: "a book move", + [MoveClassification.Opening]: "an opening move", [MoveClassification.Forced]: "forced", [MoveClassification.Brilliant]: "brilliant !!", - [MoveClassification.Great]: "a great move !", + [MoveClassification.Perfect]: "the only good move !", [MoveClassification.Best]: "the best move", [MoveClassification.Excellent]: "excellent", - [MoveClassification.Good]: "good", + [MoveClassification.Okay]: "an okay move", [MoveClassification.Inaccuracy]: "an inaccuracy", [MoveClassification.Mistake]: "a mistake", [MoveClassification.Blunder]: "a blunder", diff --git a/src/sections/analysis/panelBody/classificationTab/movesClassificationsRecap/index.tsx b/src/sections/analysis/panelBody/classificationTab/movesClassificationsRecap/index.tsx index 730086d..4c41ae4 100644 --- a/src/sections/analysis/panelBody/classificationTab/movesClassificationsRecap/index.tsx +++ b/src/sections/analysis/panelBody/classificationTab/movesClassificationsRecap/index.tsx @@ -51,11 +51,11 @@ export default function MovesClassificationsRecap() { export const sortedMoveClassfications = [ MoveClassification.Brilliant, - MoveClassification.Great, + MoveClassification.Perfect, MoveClassification.Best, MoveClassification.Excellent, - MoveClassification.Good, - MoveClassification.Book, + MoveClassification.Okay, + MoveClassification.Opening, MoveClassification.Inaccuracy, MoveClassification.Mistake, MoveClassification.Blunder, diff --git a/src/sections/analysis/panelBody/classificationTab/movesPanel/moveItem.tsx b/src/sections/analysis/panelBody/classificationTab/movesPanel/moveItem.tsx index 8d9a8fb..7ca2324 100644 --- a/src/sections/analysis/panelBody/classificationTab/movesPanel/moveItem.tsx +++ b/src/sections/analysis/panelBody/classificationTab/movesPanel/moveItem.tsx @@ -93,7 +93,7 @@ const getMoveColor = (moveClassification?: MoveClassification) => { }; const moveClassificationsToIgnore: MoveClassification[] = [ - MoveClassification.Good, + MoveClassification.Okay, MoveClassification.Excellent, MoveClassification.Forced, ]; diff --git a/src/sections/analysis/panelBody/graphTab/index.tsx b/src/sections/analysis/panelBody/graphTab/index.tsx index 71a98b1..10c44a6 100644 --- a/src/sections/analysis/panelBody/graphTab/index.tsx +++ b/src/sections/analysis/panelBody/graphTab/index.tsx @@ -66,7 +66,7 @@ export default function GraphTab(props: GridProps) { if ( [ MoveClassification.Brilliant, - MoveClassification.Great, + MoveClassification.Perfect, MoveClassification.Blunder, MoveClassification.Mistake, ].includes(moveClass) || diff --git a/src/types/enums.ts b/src/types/enums.ts index e537bdb..7aec9ec 100644 --- a/src/types/enums.ts +++ b/src/types/enums.ts @@ -18,12 +18,12 @@ export enum MoveClassification { Blunder = "blunder", Mistake = "mistake", Inaccuracy = "inaccuracy", - Good = "good", + Okay = "okay", Excellent = "excellent", Best = "best", Forced = "forced", - Book = "book", - Great = "great", + Opening = "opening", + Perfect = "perfect", Brilliant = "brilliant", }