From 93984a9fe6c278cf13330e8e3d2fb3b055adfac7 Mon Sep 17 00:00:00 2001 From: GuillaumeSD Date: Wed, 17 Apr 2024 02:02:22 +0200 Subject: [PATCH] fix : improve brilliant move classification --- src/lib/chess.ts | 2 +- src/lib/engine/helpers/moveClassification.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/chess.ts b/src/lib/chess.ts index 10835de..50fc3a7 100644 --- a/src/lib/chess.ts +++ b/src/lib/chess.ts @@ -216,7 +216,7 @@ export const getIsPieceSacrifice = ( const materialDiff = endingMaterialDifference - startingMaterialDifference; const materialDiffPlayerRelative = whiteToPlay ? materialDiff : -materialDiff; - return materialDiffPlayerRelative < -1; + return materialDiffPlayerRelative < 0; }; export const getMaterialDifference = (fen: string): number => { diff --git a/src/lib/engine/helpers/moveClassification.ts b/src/lib/engine/helpers/moveClassification.ts index 8bb4697..67720ad 100644 --- a/src/lib/engine/helpers/moveClassification.ts +++ b/src/lib/engine/helpers/moveClassification.ts @@ -168,8 +168,8 @@ const isLosingOrAlternateCompletelyWinning = ( ? positionWinPercentage < 45 : positionWinPercentage > 55; const isAlternateCompletelyWinning = isWhiteMove - ? lastPositionAlternativeLineWinPercentage > 70 - : lastPositionAlternativeLineWinPercentage < 30; + ? lastPositionAlternativeLineWinPercentage > 97 + : lastPositionAlternativeLineWinPercentage < 3; return isLosing || isAlternateCompletelyWinning; };