fix 2

bot_modules/04d_execute_culture.js

@@ -6,14 +6,17 @@
 //   'party'   → Γιορτή πόλης   (costs wood/stone/iron)
 //   'triumph' → Παρέλαση θριάμβου (costs battle points)
 //
-// On success/failure, reports back to /api/commands/<id>/result
-// so the culture_log row is updated from 'pending' to 'success'/'failed'.
+// Uses the same fire-and-forget ajaxPost pattern as all other
+// execute modules in this codebase (04a, 04b, 04c).
 // ================================================================
 
 async function executeCultureCommand(cmd) {
     if (!cmd || !cmd.id || !cmd.payload) return;
 
-    const { celebration_type, town_id } = cmd.payload;
+    // town_id lives on the command root (like build/recruit), payload has celebration_type
+    const town_id          = cmd.town_id  || cmd.payload.town_id;
+    const celebration_type = cmd.payload.celebration_type;
+
     if (!celebration_type || !town_id) {
         reportResult(cmd.id, 'failed', 'Invalid culture payload: missing celebration_type or town_id');
         return;
@@ -24,9 +27,10 @@ async function executeCultureCommand(cmd) {
         return;
     }
 
-    log(`[αγορά] Εκτέλεση ${celebration_type === 'party' ? 'Γιορτής πόλης' : 'Παρέλασης θριάμβου'} για πόλη ${town_id}`);
+    const label = celebration_type === 'party' ? 'Γιορτή πόλης' : 'Παρέλαση θριάμβου';
+    log(`[αγορά] Εκτέλεση ${label} για πόλη ${town_id}`);
 
-    // Validate town still exists in game memory
+    // Validate town exists in game memory
     const town = uw.ITowns?.towns?.[town_id];
     if (!town) {
         reportResult(cmd.id, 'failed', `Η πόλη ${town_id} δεν βρέθηκε στη μνήμη του παιχνιδιού.`);
@@ -44,58 +48,32 @@ async function executeCultureCommand(cmd) {
                     && a.celebration_type === celebration_type
                     && (a.finished_at ?? 0) > nowTs) {
                     reportResult(cmd.id, 'failed',
-                        `${celebration_type === 'party' ? 'Γιορτή' : 'Παρέλαση'} ήδη ενεργή στην πόλη ${town_id}.`);
+                        `${label} ήδη ενεργή στην πόλη ${town_id}.`);
                     return;
                 }
             }
         }
-    } catch (e) { /* model not loaded — proceed anyway, server will error if invalid */ }
+    } catch (e) { /* model not loaded — proceed; server already validated */ }
 
-    // Fire the Grepolis AJAX
-    let ajaxSuccess = false;
-    let ajaxError   = null;
+    // Human-like reaction delay — same as all other executors
+    const reactionMs = randInt(800, 2500);
+    log(`[αγορά] Waiting ${reactionMs}ms (reaction time)...`);
+    await sleep(reactionMs);
 
-    await new Promise(resolve => {
-        try {
-            uw.gpAjax.ajaxPost(
-                'building_place',
-                'start_celebration',
-                {
-                    town_id:          parseInt(town_id, 10),
-                    celebration_type: celebration_type
-                },
-                false,  // no cache-busting
-                // success callback
-                () => {
-                    ajaxSuccess = true;
-                    resolve();
-                },
-                // error callback
-                (err) => {
-                    ajaxError = err ? JSON.stringify(err) : 'Άγνωστο σφάλμα AJAX';
-                    resolve();
-                }
-            );
-        } catch (e) {
-            ajaxError = String(e);
-            resolve();
-        }
+    if (paused) {
+        reportResult(cmd.id, 'failed', 'Aborted due to pause/captcha');
+        return;
+    }
 
-        // Safety timeout: if neither callback fires within 12 s, treat as failed
-        setTimeout(() => {
-            if (!ajaxSuccess && !ajaxError) {
-                ajaxError = 'Timeout — δεν ελήφθη απάντηση από το παιχνίδι εντός 12δ.';
-            }
-            resolve();
-        }, 12000);
+    // Fire-and-forget — exact same 3-arg pattern used everywhere in this codebase.
+    // AutoFarm confirms: page=building_place, action=start_celebration,
+    // params={ celebration_type, town_id }
+    uw.gpAjax.ajaxPost('building_place', 'start_celebration', {
+        town_id:          parseInt(town_id, 10),
+        celebration_type: celebration_type
     });
 
-    if (ajaxSuccess) {
-        const label = celebration_type === 'party' ? 'Γιορτή πόλης' : 'Παρέλαση θριάμβου';
-        log(`[αγορά] ✅ ${label} ξεκίνησε επιτυχώς (πόλη ${town_id})`);
-        reportResult(cmd.id, 'done', `${label} ξεκίνησε επιτυχώς.`);
-    } else {
-        log(`[αγορά] ❌ Αποτυχία: ${ajaxError}`);
-        reportResult(cmd.id, 'failed', ajaxError || 'Αποτυχία εκτέλεσης εορτής.');
-    }
+    await sleep(500);
+    log(`[αγορά] ✅ ${label} εστάλη (πόλη ${town_id})`);
+    reportResult(cmd.id, 'done', `${label} εστάλη επιτυχώς.`);
 }