fix : move classification names rework

This commit is contained in:
GuillaumeSD
2025-05-27 22:40:40 +02:00
parent 5445c1e0e1
commit 2f38aca7b5
11 changed files with 23 additions and 23 deletions

View File

Before

Width:  |  Height:  |  Size: 1.8 KiB

After

Width:  |  Height:  |  Size: 1.8 KiB

View File

Before

Width:  |  Height:  |  Size: 2.1 KiB

After

Width:  |  Height:  |  Size: 2.1 KiB

View File

Before

Width:  |  Height:  |  Size: 1.5 KiB

After

Width:  |  Height:  |  Size: 1.5 KiB

View File

@@ -215,9 +215,9 @@ export default function Board({
bestMove && bestMove &&
showBestMoveArrow && showBestMoveArrow &&
moveClassification !== MoveClassification.Best && moveClassification !== MoveClassification.Best &&
moveClassification !== MoveClassification.Book && moveClassification !== MoveClassification.Opening &&
moveClassification !== MoveClassification.Forced && moveClassification !== MoveClassification.Forced &&
moveClassification !== MoveClassification.Great moveClassification !== MoveClassification.Perfect
) { ) {
const bestMoveArrow = [ const bestMoveArrow = [
bestMove.slice(0, 2), bestMove.slice(0, 2),

View File

@@ -5,13 +5,13 @@ export const TAB_ICONS_COLOR = "#FE7F2D";
export const LINEAR_PROGRESS_BAR_COLOR = "#3B9AC6"; export const LINEAR_PROGRESS_BAR_COLOR = "#3B9AC6";
export const CLASSIFICATION_COLORS: Record<MoveClassification, string> = { export const CLASSIFICATION_COLORS: Record<MoveClassification, string> = {
[MoveClassification.Book]: "#dbac86", [MoveClassification.Opening]: "#dbac86",
[MoveClassification.Forced]: "#dbac86", [MoveClassification.Forced]: "#dbac86",
[MoveClassification.Brilliant]: "#19d4af", [MoveClassification.Brilliant]: "#19d4af",
[MoveClassification.Great]: "#3894eb", [MoveClassification.Perfect]: "#3894eb",
[MoveClassification.Best]: "#22ac38", [MoveClassification.Best]: "#22ac38",
[MoveClassification.Excellent]: "#22ac38", [MoveClassification.Excellent]: "#22ac38",
[MoveClassification.Good]: "#74b038", [MoveClassification.Okay]: "#74b038",
[MoveClassification.Inaccuracy]: "#f2be1f", [MoveClassification.Inaccuracy]: "#f2be1f",
[MoveClassification.Mistake]: "#e69f00", [MoveClassification.Mistake]: "#e69f00",
[MoveClassification.Blunder]: "#df5353", [MoveClassification.Blunder]: "#df5353",

View File

@@ -25,7 +25,7 @@ export const getMovesClassification = (
return { return {
...rawPosition, ...rawPosition,
opening: opening.name, opening: opening.name,
moveClassification: MoveClassification.Book, moveClassification: MoveClassification.Opening,
}; };
} }
@@ -76,7 +76,7 @@ export const getMovesClassification = (
index > 1 ? [uciMoves[index - 2], uciMoves[index - 1]] : null; index > 1 ? [uciMoves[index - 2], uciMoves[index - 1]] : null;
if ( if (
isGreatMove( isPerfectMove(
lastPositionWinPercentage, lastPositionWinPercentage,
positionWinPercentage, positionWinPercentage,
isWhiteMove, isWhiteMove,
@@ -88,7 +88,7 @@ export const getMovesClassification = (
return { return {
...rawPosition, ...rawPosition,
opening: currentOpening, opening: currentOpening,
moveClassification: MoveClassification.Great, moveClassification: MoveClassification.Perfect,
}; };
} }
@@ -128,7 +128,7 @@ const getMoveBasicClassification = (
if (winPercentageDiff < -20) return MoveClassification.Blunder; if (winPercentageDiff < -20) return MoveClassification.Blunder;
if (winPercentageDiff < -10) return MoveClassification.Mistake; if (winPercentageDiff < -10) return MoveClassification.Mistake;
if (winPercentageDiff < -5) return MoveClassification.Inaccuracy; if (winPercentageDiff < -5) return MoveClassification.Inaccuracy;
if (winPercentageDiff < -2) return MoveClassification.Good; if (winPercentageDiff < -2) return MoveClassification.Okay;
return MoveClassification.Excellent; return MoveClassification.Excellent;
}; };
@@ -183,7 +183,7 @@ const isLosingOrAlternateCompletelyWinning = (
return isLosing || isAlternateCompletelyWinning; return isLosing || isAlternateCompletelyWinning;
}; };
const isGreatMove = ( const isPerfectMove = (
lastPositionWinPercentage: number, lastPositionWinPercentage: number,
positionWinPercentage: number, positionWinPercentage: number,
isWhiteMove: boolean, isWhiteMove: boolean,

View File

@@ -52,10 +52,10 @@ export default function MoveInfo() {
const bestMoveLabel = const bestMoveLabel =
moveClassification === MoveClassification.Best || moveClassification === MoveClassification.Best ||
moveClassification === MoveClassification.Book || moveClassification === MoveClassification.Opening ||
moveClassification === MoveClassification.Forced || moveClassification === MoveClassification.Forced ||
moveClassification === MoveClassification.Brilliant || moveClassification === MoveClassification.Brilliant ||
moveClassification === MoveClassification.Great moveClassification === MoveClassification.Perfect
? null ? null
: `${bestMoveSan} was the best move`; : `${bestMoveSan} was the best move`;
@@ -108,13 +108,13 @@ export default function MoveInfo() {
} }
const moveClassificationLabels: Record<MoveClassification, string> = { const moveClassificationLabels: Record<MoveClassification, string> = {
[MoveClassification.Book]: "a book move", [MoveClassification.Opening]: "an opening move",
[MoveClassification.Forced]: "forced", [MoveClassification.Forced]: "forced",
[MoveClassification.Brilliant]: "brilliant !!", [MoveClassification.Brilliant]: "brilliant !!",
[MoveClassification.Great]: "a great move !", [MoveClassification.Perfect]: "the only good move !",
[MoveClassification.Best]: "the best move", [MoveClassification.Best]: "the best move",
[MoveClassification.Excellent]: "excellent", [MoveClassification.Excellent]: "excellent",
[MoveClassification.Good]: "good", [MoveClassification.Okay]: "an okay move",
[MoveClassification.Inaccuracy]: "an inaccuracy", [MoveClassification.Inaccuracy]: "an inaccuracy",
[MoveClassification.Mistake]: "a mistake", [MoveClassification.Mistake]: "a mistake",
[MoveClassification.Blunder]: "a blunder", [MoveClassification.Blunder]: "a blunder",

View File

@@ -51,11 +51,11 @@ export default function MovesClassificationsRecap() {
export const sortedMoveClassfications = [ export const sortedMoveClassfications = [
MoveClassification.Brilliant, MoveClassification.Brilliant,
MoveClassification.Great, MoveClassification.Perfect,
MoveClassification.Best, MoveClassification.Best,
MoveClassification.Excellent, MoveClassification.Excellent,
MoveClassification.Good, MoveClassification.Okay,
MoveClassification.Book, MoveClassification.Opening,
MoveClassification.Inaccuracy, MoveClassification.Inaccuracy,
MoveClassification.Mistake, MoveClassification.Mistake,
MoveClassification.Blunder, MoveClassification.Blunder,

View File

@@ -93,7 +93,7 @@ const getMoveColor = (moveClassification?: MoveClassification) => {
}; };
const moveClassificationsToIgnore: MoveClassification[] = [ const moveClassificationsToIgnore: MoveClassification[] = [
MoveClassification.Good, MoveClassification.Okay,
MoveClassification.Excellent, MoveClassification.Excellent,
MoveClassification.Forced, MoveClassification.Forced,
]; ];

View File

@@ -66,7 +66,7 @@ export default function GraphTab(props: GridProps) {
if ( if (
[ [
MoveClassification.Brilliant, MoveClassification.Brilliant,
MoveClassification.Great, MoveClassification.Perfect,
MoveClassification.Blunder, MoveClassification.Blunder,
MoveClassification.Mistake, MoveClassification.Mistake,
].includes(moveClass) || ].includes(moveClass) ||

View File

@@ -18,12 +18,12 @@ export enum MoveClassification {
Blunder = "blunder", Blunder = "blunder",
Mistake = "mistake", Mistake = "mistake",
Inaccuracy = "inaccuracy", Inaccuracy = "inaccuracy",
Good = "good", Okay = "okay",
Excellent = "excellent", Excellent = "excellent",
Best = "best", Best = "best",
Forced = "forced", Forced = "forced",
Book = "book", Opening = "opening",
Great = "great", Perfect = "perfect",
Brilliant = "brilliant", Brilliant = "brilliant",
} }